Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Autoplay list, match chromium behavior #8408

Closed
pes10k opened this issue Feb 26, 2020 · 8 comments · Fixed by brave/brave-core#4877
Closed

Remove Autoplay list, match chromium behavior #8408

pes10k opened this issue Feb 26, 2020 · 8 comments · Fixed by brave/brave-core#4877
Labels
feature/autoplay priority/P3 The next thing for us to work on. It'll ride the trains. privacy-pod Feature work for the Privacy & Web Compatibility pod QA/No release-notes/include webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved. webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. workaround/allow-autoplay

Comments

@pes10k
Copy link
Contributor

pes10k commented Feb 26, 2020

Background

Brave currently ships with a list of domains that can autoplay video and audio; sites on the list can, everyone else cannot. This is a usability / perf feature, originally put in out of dissatisfaction with how Chrome was handling autoplay.

Problem

This breaks a bunch of sites. The list isn't maintained, its not anyone's direct responsibility. Chromium has also caught up. I super don't dig the "site engagement score" system Chromium uses for making determinations here, but since its not a privacy / security issue, I dont have strong concerns.

Suggestion

  1. Remove Brave autoplay infrastructure
  2. Just do what chromium does
  3. (only if its quick) include ability for short term escape hatch, DAT-shipped settings for chromium-determined-overrides (e.g. "example.org" -> "always autoplay", "evil.org" -> "never autoplay", etc)

Spec: https://docs.google.com/document/d/16nicZYs8uf-CLNJc0FrIucwwhzajJ9IL0yUbyCpajBM/edit#

@pes10k
Copy link
Contributor Author

pes10k commented Feb 26, 2020

cc: @rebron

@pes10k
Copy link
Contributor Author

pes10k commented Feb 26, 2020

@pes10k pes10k added feature/autoplay webcompat/shields Shields is breaking a website. webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved. workaround/allow-autoplay labels Feb 26, 2020
@BrendanEich
Copy link
Member

Is anyone able to evaluate whether this leaves things autoplaying that shouldn't be? I'm in favor but want some kind of spot check if not audit.

@pes10k
Copy link
Contributor Author

pes10k commented Feb 26, 2020

Talked with @ryanbr today, and he has heroically volunteered to do some manual eval of the diff.

So, sorted :)

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 3, 2020
@pes10k pes10k added the privacy-pod Feature work for the Privacy & Web Compatibility pod label Mar 6, 2020
@rebron rebron added this to the 1.8.x - Nightly milestone Mar 18, 2020
@LaurenWags
Copy link
Member

@pes10k @pilgrim-brave could one of you review and determine if this issue requires manual QA? if so, please add QA/Yes label and a test plan. If not, please add QA/No label. Thanks! cc @kjozwiak

@pes10k
Copy link
Contributor Author

pes10k commented Apr 9, 2020

I believe @pilgrim-brave added automated tests, so i think it shouldn't be needed, but he should confirm

@LaurenWags
Copy link
Member

@pilgrim-brave pinging on #8408 (comment) and #8408 (comment) - could you take a look please? Thanks! cc @kjozwiak @bsclifton

@pilgrim-brave
Copy link

Yes, autoplay behavior is covered by automated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/autoplay priority/P3 The next thing for us to work on. It'll ride the trains. privacy-pod Feature work for the Privacy & Web Compatibility pod QA/No release-notes/include webcompat/lists Webcompat issues that seem to be because our lists of what to or not to block could be improved. webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. workaround/allow-autoplay
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants