Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent: Should not show "Autoplay was blocked" #5359

Open
feross opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#2999
Open

WebTorrent: Should not show "Autoplay was blocked" #5359

feross opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#2999
Assignees
Labels

Comments

@feross
Copy link

feross commented Jul 23, 2019

Description

The WebTorrent extension is provided by the Brave browser, so it's kind of silly for the browser to display a notification that autoplay has been blocked.

Steps to Reproduce

  1. Go to https://webtorrent.io/free-torrents
  2. Click on Big Buck Bunny (torrent file)
  3. Start download
  4. Right click on "Big Buck Bunny.mp4" and "Open Link in New Tab" (to workaround Webtorrent file doesn't stream when file name is clicked on #3966)
  5. The browser shows a notification about blocking autoplay.

Actual result:

Screen Shot 2019-07-23 at 3 49 02 PM

Expected result:

Either we should:

  1. Successfully autoplay the video, or
  2. Not attempt autoplay if the browser is going to block it, or
  3. Start autoplaying with the audio muted (this will not be blocked).

Does anyone on the Design team have feedback on which choice is best? I lean toward option 1, as that's what we did in the past (until it stopped working with the Chrome Autoplay policy changes)

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes
@yrliou
Copy link
Member

yrliou commented Sep 16, 2019

Talked to @feross before that the fix was incomplete since we could still reproduce it, so reopen this issue and remove its milestone for now.

@yrliou yrliou reopened this Sep 16, 2019
@yrliou yrliou removed this from the 0.69.x - Release milestone Sep 16, 2019
@feross
Copy link
Author

feross commented Sep 16, 2019

@yrliou Sounds good. Thanks for reopening this.

@rebron
Copy link
Collaborator

rebron commented Apr 28, 2020

@yrliou This issue should no longer be valid due to #8408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants