-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add padding and shadow to main content window #31645
Labels
front-end-change
This task is a front end task and doesn't need any C++ changes
needs-discussion
Although the issue is clear, we haven't yet reached a decision about the right solution.
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
Milestone
Comments
rebron
added
needs-discussion
Although the issue is clear, we haven't yet reached a decision about the right solution.
QA/Yes
release-notes/include
OS/Desktop
front-end-change
This task is a front end task and doesn't need any C++ changes
priority/P4
Planned work. We expect to get to it "soon".
labels
Jul 14, 2023
25 tasks
rebron
added
priority/P3
The next thing for us to work on. It'll ride the trains.
and removed
priority/P4
Planned work. We expect to get to it "soon".
labels
Sep 27, 2023
This was referenced Oct 13, 2023
Added |
Verified
|
before enabling the flag | after enabling the flag - vertical | after enabling the flag - horizontal |
---|---|---|
before enabling the flag | after enabling the flag - sidebar panel |
---|---|
Dark
mode
before enabling the flag | after enabling the flag - vertical | after enabling the flag - horizontal |
---|---|---|
before enabling the flag | after enabling the flag - sidebar panel |
---|---|
stephendonner
added
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
QA Pass-macOS
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Nov 6, 2023
LaurenWags
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Nov 20, 2023
Verification in progress with
Encountered #34454 while testing. Steps:
Confirmed padding and shadow is applied to main content window, to show separationConfirmed border radius is shown for all four corners - Encountered #34067Horizontal tabs
|
before enabling the flag | after enabling the flag |
---|---|
Horizontal tabs Dark
mode
before enabling the flag | after enabling the flag |
---|---|
Vertical tabs Light
mode
before enabling the flag | after enabling the flag |
---|---|
Vertical tabs Dark
mode
before enabling the flag | after enabling the flag |
---|---|
changing to |
LaurenWags
added
release-notes/exclude
QA Pass-Linux
and removed
release-notes/include
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Nov 20, 2023
Verification PASSED on
Steps:
Confirmed padding and shadow is applied to main content window, to show separationConfirmed border radius is shown for all four corners - Encountered #34067Horizontal tabs
|
before enabling the flag | after enabling the flag |
---|---|
Horizontal tabs Dark
mode
before enabling the flag | after enabling the flag |
---|---|
Vertical tabs Light
mode
before enabling the flag | after enabling the flag |
---|---|
Vertical tabs Dark
mode
before enabling the flag | after enabling the flag |
---|---|
Verification
Steps:
Light mode/Horizontal View
Light mode/Vertical tab view
Dark mode/Horizontal tab view
Dark mode/Vertical tab view
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
front-end-change
This task is a front end task and doesn't need any C++ changes
needs-discussion
Although the issue is clear, we haven't yet reached a decision about the right solution.
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
Description
Add padding and shadow to main content window to show separation. Add border radius to all four corners.
This will allow for clear separation when vertical and sidebar are open.
Design
Figma: https://www.figma.com/file/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?type=design&node-id=186%3A17108&mode=design&t=nhfxV22NiGDSYN2e-1
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: