Enable rounded webview corners in desktop Nightly and Beta #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjozwiak
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM 👍 @zenparsing you usually don't need approval to merge a study into main. The usual process is to get both the main & production PRs created and then merge into staging. Once merged, I'll notice the production PR and will verify on staging before merging into production.
|
|
Example |
Example |
Example |
|---|---|---|
 |
 |
 |
BETA on Win 11 x64
BraveWebViewRoundedCornersStudy:Enabled
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.61.74 Chromium: 119.0.6045.134 (Official Build) beta (64-bit)
-- | --
Revision | dd4ee965ff1042897c081140d2ed1ccfe9c6d43f
OS | Windows 11 Version 22H2 (Build 22621.2506)
- launched
1.61.74 Chromium: 119.0.6045.134usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
BraveWebViewRoundedCornersStudywasn't being displayed viabrave://version - ensured that
webviewcorners are not rounded - restarted Brave once again using
brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
BraveWebViewRoundedCornersStudy:Enabled - ensured that the
webviewcorners are rounder/appearing as expected
Example |
Example |
Example |
|---|---|---|
 |
 |
 |
Release on Win 11 x64
BraveWebViewRoundedCornersStudy not being used
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.60.114 Chromium: 119.0.6045.124 (Official Build) (64-bit)
-- | --
Revision | 99a34933fc6a44fdfe52dea41341927bbce3549a
OS | Windows 11 Version 22H2 (Build 22621.2506)
- launched
1.60.114 Chromium: 119.0.6045.124usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
BraveWebViewRoundedCornersStudywasn't being displayed viabrave://version - ensured that
webviewcorners are not rounded - restarted Brave once again using
brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
BraveWebViewRoundedCornersStudywasn't being displayed viabrave://version - ensured that
webviewcorners are not rounded
Example |
Example |
Example |
|---|---|---|
 |
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables brave/brave-browser#31645 on Beta and Nightly.
Feature flag:
#brave-web-view-rounded-corners