Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script blocked count included allowed scripts as well #3174

Open
srirambv opened this issue Jan 31, 2019 · 2 comments
Open

Script blocked count included allowed scripts as well #3174

srirambv opened this issue Jan 31, 2019 · 2 comments
Labels
bug feature/shields/!scripts Blocking JavaScript with Shields priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Script blocked count included allowed scripts as well

Steps to Reproduce

  1. Visit https://brainbondy.com
  2. Block scripts from shields
  3. Go to details view and Undo on domain name
  4. Shows one entry under Allowed and two entries under Blocked
  5. Total count shows count of both included and allowed scripts

Actual result:

shields

Expected result:

Should only show blocked items count even if there is a script that is allowed that shouldn't be counted

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Additional Information

cc: @karenkliu @diracdeltas @tomlowenthal @rebron @brave/legacy_qa

@srirambv srirambv added this to the 1.x Backlog milestone Jan 31, 2019
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Jan 31, 2019
@rebron
Copy link
Collaborator

rebron commented Feb 1, 2019

@cezaraugusto is this a front end issue? can you take a look?

@kjozwiak
Copy link
Member

kjozwiak commented Feb 5, 2019

Reproduced on Win 10 x64 using the STR @srirambv provided above. Example:

blockedscripts

Used the following build to reproduce the issue:

Brave 0.61.7 Chromium: 72.0.3626.81 (Official Build) dev (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@cezaraugusto cezaraugusto self-assigned this Mar 8, 2019
@cezaraugusto cezaraugusto removed their assignment May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/!scripts Blocking JavaScript with Shields priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants