Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to block scripts individually #2449

Closed
wants to merge 20 commits into from

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#4336 (Too much bottom padding on scripts details view)
fix brave/brave-browser#4228 (Different number of scripts blocked in main view and detailed view)
fix brave/brave-browser#3431 (Change Shields numbers to count FQDNs rather than total requests)
fix brave/brave-browser#3367 (Show domain / subdomain not the full path for HTTPS detail view)
fix brave/brave-browser#3239 (Widen Shields panel to avoid text wrapping)
fix brave/brave-browser#2371 (Remove Block all text when there are no entries)
fix brave/brave-browser#3174 (Script blocked count included allowed scripts as well)
address brave/brave-browser#2996 (Surface script blocking shortcuts to "Allow once", fix scripts functionality, focus indicators, and scroll)

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto cezaraugusto self-assigned this May 15, 2019
@cezaraugusto cezaraugusto changed the title Add option to block scripts individually Add support for blocking scripts individually May 15, 2019
@cezaraugusto cezaraugusto changed the title Add support for blocking scripts individually Add support to block scripts individually May 15, 2019
@cezaraugusto
Copy link
Contributor Author

closing in favor of #2485

@cezaraugusto cezaraugusto deleted the ca-noscript-individually branch May 23, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment