Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen Shields panel to avoid text wrapping #3239

Closed
tildelowengrimm opened this issue Feb 5, 2019 · 3 comments
Closed

Widen Shields panel to avoid text wrapping #3239

tildelowengrimm opened this issue Feb 5, 2019 · 3 comments
Assignees
@karenkliu
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. priority/P3 The next thing for us to work on. It'll ride the trains.
Milestone
Closed / Dupe / I...

Comments

@tildelowengrimm
Copy link
Contributor

Some of the legends on the Shields panel are cut off because of the panel's width. Let's make the panel wider so this doesn't happen, even in longer languages.
@tildelowengrimm tildelowengrimm added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P3 The next thing for us to work on. It'll ride the trains. feature/shields/panel Front-end design and functionality of the Shields panel. labels Feb 5, 2019
@karenkliu
Copy link

This is mostly avoided with the new updates in #2565, which includes widening the panel so that it's the same width as the Rewards panel. Please also take a look at the specs in #2996 which tests the UI in Russian, the language that usually has the longest text strings.

@cezaraugusto cezaraugusto mentioned this issue May 15, 2019
Closed
6 tasks
@cezaraugusto
Copy link
Contributor

can we close this? I guess we're in a good size now cc @karenkliu

@karenkliu
Copy link

Yeah I think this issue is out of date.

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

Successfully merging a pull request may close this issue.

Add support to block scripts individually brave/brave-core
5 participants
@tildelowengrimm @bbondy @karenkliu @cezaraugusto @bsclifton