Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show domain / subdomain not the full path for HTTPS detail view #3367

Closed
karenkliu opened this issue Feb 15, 2019 · 0 comments · Fixed by brave/brave-core#2529
Closed

Show domain / subdomain not the full path for HTTPS detail view #3367

karenkliu opened this issue Feb 15, 2019 · 0 comments · Fixed by brave/brave-core#2529
Assignees
@karenkliu
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. priority/P3 The next thing for us to work on. It'll ride the trains.
Milestone
Closed / Dupe / I...

Comments

@karenkliu
Copy link

karenkliu commented Feb 15, 2019 •
edited
Loading

Description

Currently the read only view of connections upgraded to HTTPS shows the full path. Truncate the path so that only the domain / subdomain shows, following the same rules that were applied to the scripts detail panel (#2996).

Designs

detail view - https
@karenkliu karenkliu added the feature/shields/panel Front-end design and functionality of the Shields panel. label Feb 15, 2019
@karenkliu karenkliu self-assigned this Feb 15, 2019
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 15, 2019
@karenkliu karenkliu changed the title Show domain / subdomain not the full path for read-only views Show domain / subdomain not the full path for HTTPS detail view Mar 25, 2019
@cezaraugusto cezaraugusto mentioned this issue May 15, 2019
Closed
6 tasks
@cezaraugusto cezaraugusto self-assigned this May 28, 2019
@cezaraugusto cezaraugusto mentioned this issue May 28, 2019
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue May 28, 2019
@cezaraugusto
only show hostname of HTTPS upgrades in details view
420821f 
close brave/brave-browser#3367
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

Labels
feature/shields/panel Front-end design and functionality of the Shields panel. priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
Closed / Dupe / Invalid
4 participants
@tildelowengrimm @bbondy @karenkliu @cezaraugusto