Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only show hostname of HTTPS upgrades in details view #2529

Merged
merged 1 commit into from
May 29, 2019
Merged

only show hostname of HTTPS upgrades in details view #2529

merged 1 commit into from
May 29, 2019

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented May 28, 2019 •
edited
Loading

Screen Shot 2019-05-28 at 20 36 59

close brave/brave-browser#3367

Test Plan

  1. Go to https-everywhere.badssl.com
  2. Open Shields HTTPS detail view
  3. Should show only the resource hostname

@cezaraugusto cezaraugusto self-assigned this May 28, 2019
yrliou
yrliou requested changes May 29, 2019
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint
ERROR: /home/travis/build/brave/brave-core/components/brave_extension/extension/brave_extension/components/list/httpsUpgrades.tsx:28:1 - Consecutive blank lines are forbidden

@cezaraugusto cezaraugusto merged commit 6cbbbc6 into master May 29, 2019
@cezaraugusto cezaraugusto deleted the ca-3367 branch May 29, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

@Snuupy Snuupy Awaiting requested review from Snuupy

Assignees

@cezaraugusto cezaraugusto

Labels
feature/shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show domain / subdomain not the full path for HTTPS detail view
2 participants
@cezaraugusto @yrliou