Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much bottom padding on scripts details view #4336

Closed
srirambv opened this issue May 7, 2019 · 1 comment
Closed

Too much bottom padding on scripts details view #4336

srirambv opened this issue May 7, 2019 · 1 comment
Assignees
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented May 7, 2019

Description

Too much bottom padding on scripts details view

Steps to Reproduce

  1. Block scripts on a page
  2. Open details view of scripts blocked
  3. Too much bottom padding for Go Back and Cancel buttons

Actual result:

Screenshot from 2019-05-07 12-49-09

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    No
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the dev channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Does the issue resolve itself when disabling Brave Rewards?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

cc: @karenkliu @cezaraugusto

@cezaraugusto
Copy link
Contributor

this was fixed after brave/brave-ui@4eeb39e landed in brave-core so I'm closing this one. @srirambv please re-open if you think I'm wrong

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants