-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different number of scripts blocked in main view and detailed view #4228
Comments
This has always been the behaviour. Was briefly discussed here https://bravesoftware.slack.com/archives/CD495CWLR/p1548828086062300 cc: @karenkliu |
The block count should count individual scripts blocked both on the main panel and scripts detail view. Detail view of scripts should have a matching number. @cezaraugusto mentioned he is able to show each individual script now, so that will help clear up the confusion; if there are 18 blocked scripts the user can go into the scripts detail view to see 18 items listed. |
- scripts now use the same method for checking scripts blocked fix brave/brave-browser#4228
- scripts now use the same method for checking scripts blocked fix brave/brave-browser#4228
- scripts now use the same method for checking scripts blocked fix brave/brave-browser#4228
Awesome work! Verification passed on
Used test plan from brave/brave-core#2485 Verification passed on
Verified passed with
|
Steps to Reproduce
https://www.poboczem.pl/video,vId,2681150
Actual result:
Different number of scripts blocked in main view and detailed view
Main view shows 18 scripts blocked:
Detailed view shows 3 scripts blocked
Expected result:
The same number of scripts blocked in main view and detailed view
Edit: The detailed view does not show actual scripts blocked, but it shows domains only. Maybe we should rename
Scripts blocked
toDomains blocked
.Reproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @brave/legacy_qa @tomlowenthal
The text was updated successfully, but these errors were encountered: