Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks on device where sync was reset isn't sent across the chain #3188

Closed
srirambv opened this issue Feb 1, 2019 · 1 comment · Fixed by brave/brave-core#1560
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2019

Description

Bookmarks on device where sync was reset isn't sent across the chain.

Devices

Device 1: Samsung Tab running 1.0.76
Device 2: Pixel 3XL running 1.0.76
Device 3: Linux running 0.59.34 profile 1 (Sync already created and reset)
Device 4: Linux running 0.59.34 profile 2

Steps to Reproduce

  1. Create bookmarks and folders on device 1
  2. Create sync chain on Device 1 and scan QR code on device 2, ensure all bookmarks are sync'd on device2
  3. Reset existing sync on device 3 which has existing bookmarks
  4. Enter code words from device 1 and join device 3 on the sync chain, bookmarks from device 1 sync on device 3
  5. Existing bookmarks from device 3 isn't sync'd to device 1 or device 2
  6. Create bookmarks on device 4 and join the sync chain using code words
  7. Once device is listed, device 4 sync's all bookmarks from device 1, similarly device 1,2 & 3 sync's all bookmarks from device 4

Actual result:

Device 1
screenshot_20190201-051813_brave
Device 2
screenshot_20190201-154748
Device 3 (Contains 2 bookmark folder Linux and Windows which doesn't sync)
screenshot from 2019-02-01 15-46-41
Device 4
screenshot from 2019-02-01 15-47-14

Expected result:

Irrespective of previous sync state all bookmarks should be sync'd across all devices

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Linux

Android Build 1.0.76

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @SergeyZhukovsky @brave/legacy_qa @AlexeyBarabash @darkdh

@srirambv srirambv added this to the 1.x Backlog milestone Feb 1, 2019
@AlexeyBarabash AlexeyBarabash self-assigned this Feb 1, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 1, 2019
@AlexeyBarabash AlexeyBarabash modified the milestones: 1.x Backlog, 0.62.x - Nightly Feb 6, 2019
@btlechowski
Copy link

btlechowski commented Feb 27, 2019

Verification passed on

Brave 0.61.38 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used STR from brave/brave-core#1560.
All the devices got the expected bookmarks.

Verification passed on

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint

Verified passed with

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants