-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync don't do double reset #1560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Feb 4, 2019
Updated first message with issue for zombies brave/brave-browser#3225 . |
darkdh
previously approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please squash some commits if necessary.
AlexeyBarabash
force-pushed
the
sync_dont_double_reset
branch
from
February 5, 2019 21:01
8d05810
to
09cf7bb
Compare
@darkdh |
darkdh
reviewed
Feb 5, 2019
AlexeyBarabash
force-pushed
the
sync_dont_double_reset
branch
from
February 5, 2019 21:51
09cf7bb
to
2340132
Compare
darkdh
approved these changes
Feb 5, 2019
AlexeyBarabash
added a commit
that referenced
this pull request
Feb 7, 2019
Sync don't do double reset
AlexeyBarabash
added a commit
that referenced
this pull request
Feb 7, 2019
Sync don't do double reset
AlexeyBarabash
added a commit
that referenced
this pull request
Feb 7, 2019
Merge pull request #1560 from brave/sync_dont_double_reset
bbondy
added a commit
that referenced
this pull request
Feb 12, 2019
Merge pull request #1560 from brave/sync_dont_double_reset (0.60.x)
This was referenced Feb 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#3188 .
Fix brave/brave-browser#3225 .
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Taken from brave/brave-browser#3188
Devices
Device 1: Samsung Tab running 1.0.76
Device 2: Pixel 3XL running 1.0.76
Device 3: Linux running 0.59.34 profile 1 (Sync already created and reset)
Device 4: Linux running 0.59.34 profile 2
Steps to Reproduce
Taken from brave/brave-browser#3225
Steps to Reproduce
View sync code
->View QR code
, do the screenshot of QR codeLeave Sync Chain
Reviewer Checklist: