add funds link on tip banner yields no action - follow up to 2628

[LaurenWags]

Description

Follow up to #2628

Clicking on add funds link in site tipping banner doesn't do anything. It should link to brave://rewards/#add-funds as the panel does.

Steps to Reproduce

• Clean install
• enable rewards
• Visit site and open rewards panel
• Click Send a tip...
• Choose tip amount
• Click add funds link

Actual result:

Nothing happens

Expected result:

Should link to brave://rewards/#add-funds

Reproduces how often:

easy

Brave version (brave://version info)

Brave	0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision	ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

[NejcZdovc]

link is there, but get this error in the console

If I have it like this:

then we get an error. But if I change it to

then it works.

cc @bbondy @bridiver did we change some permissions where we only allow chrome links?

[NejcZdovc]

@LaurenWags so link is there and all code is correct. At some point we apparently changed permissions and brave links are blocked in webui

[NejcZdovc]

this was changed with brave/brave-core#1196, so will create PR to change from brave to chrome

[GeetaSarvadnya]

Reproducible on windows 10 x64 - 0.60.19 -Getting console error, when click on add funds link:

[LaurenWags]

Verified passed with

Brave	0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Mac OS X

• Verified test plan from Renames links from brave to chrome brave-core#1580

Verification passed on

Brave	0.60.23 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Windows 10

• Verified test plan from Renames links from brave to chrome brave-core#1580

Verification passed on

Brave	0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Linux

• Verified test plan from Renames links from brave to chrome brave-core#1580