Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 0.61.7 or later will show blank auto contribute table - follow up to 2110 #3250

Closed
LaurenWags opened this issue Feb 6, 2019 · 2 comments · Fixed by brave/brave-core#1626

Comments

@LaurenWags
Copy link
Member

Description

Once you upgrade to 0.61.7 or later on Dev channel, your auto contribute table will show as blank. Per discussion with @NejcZdovc we need to update existing entries in the table to have a visit number.

Steps to Reproduce

  1. Create a clean profile on Dev channel using 0.61.6 or earlier.
  2. Enable Rewards
  3. Visit some sites (I had a mix of verified and non-verified sites).
  4. Visit brave://settings/help to trigger update.
  5. Relaunch once update is complete.

Actual result:

A-C table is blank.

Expected result:

A-C table should not be blank.

Reproduces how often:

easily. Reproduced by @NejcZdovc and @kjozwiak

Brave version (brave://version info)

Brave 0.61.10 Chromium: 72.0.3626.81 (Official Build) dev(64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

Also occurs if you update to 0.61.7 on Dev.

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Dev

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Here is a macOS profile created using 0.61.6 that can be used to reproduce the issue:
Brave-Browser-Dev-upgradeandACisblank.zip

@LaurenWags LaurenWags added bug feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes QA/Test-Plan-Specified labels Feb 6, 2019
@LaurenWags LaurenWags added this to the 1.x Backlog milestone Feb 6, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 7, 2019

Reproducible on Windows 10 x64. Upgraded from 0.61.6 to 0.61.10

Brave 0.61.10 Chromium: 72.0.3626.81 (Official Build) dev (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 10

@btlechowski
Copy link

btlechowski commented Feb 27, 2019

Verification passed on

Brave 0.61.38 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from the description. Renamed the dev profile to beta.
Made sure that visits in publisher_info_db was 0 before the upgrade and after upgrade it was 1.

Verification passed on

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint
  • Verified the STR from Adds migration for min visits brave-core#1626 (moved profiles as one is dev and
    other is beta)
    • Verified that visits in publisher_info_db was 0 before upgrade and after upgrade it was 1
  • Verified the STR mentioned in the description
    • Verified that user can add new sites to a-c table after upgrade
    • Verified that user can revisit existing sites and attention % rate is increased after revisit
    • Verified that user can change the a-c settings to 5sec and add new sites to a-c table
    • Verified that user can revisit existing sites after changing a-c settings, and % rate increased after
      revisit

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X
  • Verified the STR from Adds migration for min visits brave-core#1626 (using profile from description)
    • Verified that visits in publisher_info_db was 0 before upgrade and after upgrade it was 1
  • Verified the STR mentioned in the description
    • Verified that user can add new sites to a-c table after upgrade
    • Verified that user can revisit existing sites and attention % rate is increased after revisit
    • Verified that user can change the a-c settings to 5sec and add new sites to a-c table
    • Verified that user can revisit existing sites after changing a-c settings, and % rate increased after revisit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants