-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insufficient Funds notification text needs update #3286
Labels
bug
feature/rewards
OS/macOS
OS/Windows
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
LaurenWags
added
bug
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA/Yes
QA/Test-Plan-Specified
labels
Feb 8, 2019
Also reproduced on Ubuntu 17.10
|
Verification passed on
Used test plan from brave/brave-core#1723 Verified passed with
Used test plan from brave/brave-core#1723 |
Follow up issue logged for linux #3786 |
Reproduced and commented results under #3786 (comment). |
Marking as Windows and macOS as its still failing on Linux and followup issue(#3786 ) for Linux is logged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/rewards
OS/macOS
OS/Windows
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Description
Found while testing #1479
Insufficient Funds notification references Brave Payments, this text should be updated.
@mandar-brave please provide text for notification.
Steps to Reproduce
- -rewards=reconcile-interval=4340
Actual result:
Notification displays with text referencing Brave Payments:
Expected result:
Notification should probably reference Brave Rewards, but @mandar-brave should provide text to be used.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: