Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient Funds notification text needs update #3286

Closed
LaurenWags opened this issue Feb 8, 2019 · 6 comments · Fixed by brave/brave-core#1723
Closed

Insufficient Funds notification text needs update #3286

LaurenWags opened this issue Feb 8, 2019 · 6 comments · Fixed by brave/brave-core#1723

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #1479

Insufficient Funds notification references Brave Payments, this text should be updated.

@mandar-brave please provide text for notification.

Steps to Reproduce

  1. Launched Brave with - -rewards=reconcile-interval=4340
  2. Enable Rewards
  3. Visit a site.
  4. Wait 15-20 minutes

Actual result:

Notification displays with text referencing Brave Payments:
screen shot 2019-02-08 at 6 04 30 pm

Expected result:

Notification should probably reference Brave Rewards, but @mandar-brave should provide text to be used.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags LaurenWags added bug feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes QA/Test-Plan-Specified labels Feb 8, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 14, 2019
@btlechowski
Copy link

Also reproduced on Ubuntu 17.10

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

@btlechowski
Copy link

btlechowski commented Mar 6, 2019

Verification passed on

Brave 0.62.17 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1723

image

Verified passed with

Brave 0.62.28 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Used test plan from brave/brave-core#1723

Screen Shot 2019-03-15 at 3 46 07 PM

@srirambv
Copy link
Contributor

srirambv commented Mar 19, 2019

Seeing Brave Payments on

Brave 0.62.32 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

cc: @kjozwiak to try on his Linux machine

@srirambv
Copy link
Contributor

Follow up issue logged for linux #3786

@kjozwiak
Copy link
Member

cc: @kjozwiak to try on his Linux machine

Reproduced and commented results under #3786 (comment).

@srirambv
Copy link
Contributor

Marking as Windows and macOS as its still failing on Linux and followup issue(#3786 ) for Linux is logged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants