Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe Sign support for CoW 🐮 orders #33093

Closed
onyb opened this issue Sep 18, 2023 · 1 comment · Fixed by brave/brave-core#20203
Closed

Safe Sign support for CoW 🐮 orders #33093

onyb opened this issue Sep 18, 2023 · 1 comment · Fixed by brave/brave-core#20203
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.60.x - Release

Comments

@onyb
Copy link
Member

onyb commented Sep 18, 2023

Parse EIP-712 messages corresponding to CoW swap and limit orders, and render them in the Safe Sign UI, previously designed for 0x swaps.

Example swap: https://swap.cow.fi/#/100/swap/WXDAI
@onyb onyb self-assigned this Sep 18, 2023
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Sep 18, 2023
@onyb onyb mentioned this issue Sep 18, 2023
Merged
25 tasks
@StephenHeaps StephenHeaps mentioned this issue Sep 20, 2023
Closed
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 25, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.60.104 Chromium: 118.0.5993.117 (Official Build) (64-bit)
Revision 5dfa047eac682ad367174af6503fc21b59db5977
OS Windows 11 Version 22H2 (Build 22621.2428)
  • Verified steps from brave/brave-core#20203
  • Verified able to place order on https://swap.cow.fi
  • Verified able to place order with a custom recipient on https://swap.cow.fi
  • Verified able to view order details by clicking on the Details button in the confirmation screen
  • Verified able to place Swap order on native tokens on https://swap.cow.fi
  • Verified able to place Swap order on unknown tokens via 0x Swap

Case A: CoW Swap trade

Raw Details
brave_n3ehi3E6Bw brave_pNoXAiuhCM

Case B: CoW Swap trade with custom recipient

Raw Details
brave_IcKitSiteR brave_OvvUIQqOeu

Case C: CoW swap trade selling native asset (ETH on Ethereum)
brave_buaTl6oUq9

Case D: 0x Swap involving unknown tokens
brave_kDgZkIYRz4

@onyb onyb mentioned this issue Oct 26, 2023
Open
@LaurenWags LaurenWags mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.60.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): support CoW 🐮 orders in Safe Sign brave/brave-core
4 participants
@jamesmudgett @onyb @srirambv @brave-builds