Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe Sign support for CoW 🐮 orders (android) #33950

Open
onyb opened this issue Oct 26, 2023 · 0 comments
Open

Safe Sign support for CoW 🐮 orders (android) #33950

onyb opened this issue Oct 26, 2023 · 0 comments
Labels
OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include

Comments

@onyb
Copy link
Member

onyb commented Oct 26, 2023

Android follow-up issue for #33093

Requirements:

  1. Core has the parsing work done, we should display these requests in our existing Safe Sign UI previously designed for 0x swaps.
  2. Use GetEthTokenSymbol / GetEthTokenDecimals for unknown tokens.
  3. When finding non-nil EthSignTypedDataMeta? meta;, display "Free" for the network fee as it's a sign request not a transaction.
@onyb onyb added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Oct 26, 2023
@onyb onyb added this to Web3 Oct 26, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include
Projects
Web3
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onyb