Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC delete doesn't remove duration from the table #3459

Closed
NejcZdovc opened this issue Feb 22, 2019 · 3 comments · Fixed by brave/brave-core#1889
Closed

AC delete doesn't remove duration from the table #3459

NejcZdovc opened this issue Feb 22, 2019 · 3 comments · Fixed by brave/brave-core#1889

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 22, 2019

Description

Steps to Reproduce

  1. enable rewards
  2. visit a site
  3. make sure that you see it in ac table
  4. delete that site
  5. restore this site

Actual result:

Site is listed with duration and %.

Expected result:

Site shouldn't be shown and data in the db should be deleted for the current month

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 22, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 22, 2019
@NejcZdovc NejcZdovc changed the title Restore doesn't remove entry from the table AC delete doesn't remove duration from the table Feb 22, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 22, 2019
@NejcZdovc NejcZdovc removed their assignment Feb 22, 2019
@NejcZdovc NejcZdovc self-assigned this Mar 7, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 7, 2019
@NejcZdovc NejcZdovc added this to the 0.64.x - Nightly milestone Mar 8, 2019
@GeetaSarvadnya
Copy link

Blocked and unable to test due to #3850

@kjozwiak
Copy link
Member

@GeetaSarvadnya what you noticed in #3850 is expected behaviour. This issue fixes that. When you're restoring a removed website from the table, it won't restore the past duration.

@btlechowski
Copy link

btlechowski commented Mar 28, 2019

Verification passed on

Brave 0.64.24 Chromium: 73.0.3683.75 (Official Build) nightly (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#1889
Also checked that the publisher can be re-added to the a-c table after being restored.

Verification passed on

Brave 0.64.25 Chromium: 73.0.3683.75 (Official Build) nightly (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Verified passed with

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta(64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X
  • Reproduced issue on current release version 0.63.48 and verified fixed with 0.64.60.
  • Verified test plan from Remove activity info when publisher is excluded brave-core#1889
  • Verified publisher can be re-added to the a-c table after being restored.
  • Verified publisher can be re-added to the a-c table via the 'Include' toggle on panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants