Crash when I close a tab

[errodriguez]

IMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it.

Brave Version: 1.61.101 Chromium: 120.0.6099.71
Operating System: Mac OS X 14.1.2

URL (if applicable) where crash occurred: NA

Can you reproduce this crash?

Yes. It happens either when I restore my tabs or not. No pattern or something special... it just happens when I close any tab.

What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?)

1. Launch browser.
2. Open any page in a new tab.
3. Close the page.
4. Browser crashes.

DO NOT CHANGE BELOW THIS LINE
Crash ID: crash/af320100-8bde-260b-0000-000000000000

[errodriguez]

It happens when you try to open a new tab after closing a previous one.

[errodriguez]

And... it looks like it only happens if you close the tab using the contextual menu.

[rebron]

@errodriguez Do you have the Dark Reader mode extension? Thanks for sending the crash report.

[errodriguez]

No, I don't have that extension. I do have other ones. I installed them some time ago.

[atuchin-m]

The same callstack as in #34783

[ 00 ] TabStripModel::IsTabSelected(int) const ( immediate_crash.h:146 )
[ 01 ] TabStripModel::GetIndicesForCommand(int) const ( tab_strip_model.cc:1786 )
[ 02 ] BraveTabContextMenuContents::IsBraveCommandIdEnabled(int) const ( brave_tab_strip_model.cc:83 )
[ 03 ] BraveTabContextMenuContents::IsCommandIdEnabled(int) const ( brave_tab_context_menu_contents.cc:76 )
[ 04 ] ui::SimpleMenuModel::IsEnabledAt(unsigned long) const ( simple_menu_model.cc:474 )
[ 05 ] -[MenuControllerCocoa validateUserInterfaceItem:] ( menu_controller.mm:313 )
[ 06 ] -[MenuControllerCocoa validateUserInterfaceItem:] ( menu_controller.mm:313 )
[ 07 ] 0x18d02c594
[ 08 ] 0x18d02c080
[ 09 ] 0x18d6bc858
[ 10 ] 0x18d543810
[ 11 ] 0x18d468674
[ 12 ] 0x18d46bee8
[ 13 ] 0x18cf4568c
[ 14 ] 0x18cf44e14
[ 15 ] 0x18d1678f0
[ 16 ] __67-[MenuControllerCocoaDelegateImpl controllerWillAddMenu:fromModel:]_block_invoke ( menu_controller_cocoa_delegate_impl.mm:242 )
[ 17 ] 0x1896e2808
[ 18 ] 0x1897768e8
[ 19 ] 0x189776830
[ 20 ] 0x1896b1488
[ 21 ] 0x18a7a302c
[ 22 ] 0x18cfc90b8
[ 23 ] 0x18d968b2c
[ 24 ] -[NativeWidgetMacNSWindow orderWindow:relativeTo:] ( native_widget_mac_nswindow.mm:504 )
[ 25 ] 0x18d9746b0
[ 26 ] 0x18d08e248
[ 27 ] 0x18cf08aac
[ 28 ] 0x18d08d6c8
[ 29 ] -[NativeWidgetMacNSWindow addChildWindow:ordered:] ( native_widget_mac_nswindow.mm:237 )
[ 30 ] remote_cocoa::NativeWidgetNSWindowBridge::OrderChildren() ( native_widget_ns_window_bridge.mm:1663 )
[ 31 ] remote_cocoa::NativeWidgetNSWindowBridge::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState) ( native_widget_ns_window_bridge.mm:800 )
[ 32 ] views::NativeWidgetMac::Show(ui::WindowShowState, gfx::Rect const&) ( native_widget_mac.mm:614 )
[ 33 ] views::Widget::Show() ( widget.cc:0 )
[ 34 ] views::WidgetFadeAnimator::FadeIn() ( widget_fade_animator.cc:30 )
[ 35 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ( callback.h:154 )
[ 36 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:326 )
[ 37 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:0 )
[ 38 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ( callback.h:154 )
[ 39 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:326 )
[ 40 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:0 )
[ 41 ] base::MessagePumpCFRunLoopBase::RunWork() ( message_pump_apple.mm:444 )
[ 42 ] base::apple::CallWithEHFrame(void () block_pointer)

[errodriguez]

And... it looks like it is time-dependent; if you close one tab and immediately switch to another, the browser will collapse. I've been waiting two or three seconds before closing or moving to another tab, and no crashes until now.