-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for controlling how blocking is done at a high level #3489
Labels
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
bbondy
added
the
priority/P2
A bad problem. We might uplift this to the next planned release.
label
Feb 25, 2019
This was referenced Feb 25, 2019
19 tasks
cc: @karenkliu |
This was referenced Mar 15, 2019
This was referenced Mar 21, 2019
Verification passed on
Verification passed on
Verification passed on
Used test plan from the description Verified passed with
Verification PASSED on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
This is Step 2 of the plan outlined in this issue:
#3475
In the section "Summary of the plan"
It looks like this:
Step 2: Add options to easily disable the exception rules, it will be allowed by default when this step lands as it is today for FB login buttons, embedded tweets, and embedded FB posts.
This will allow you to uncheck things, and it will look like:
Test Plan
Before testing on this can be done, the data-files must be updated from:
brave/adblock-lists#54
If that pull request is closed, then you can assume they are updated.
Note that between reloads you need to do a clean reload (cmd+shift+r) so that it doesn't use cache.
Test logins to the following sites work:
https://twitch.tv FB login
https://quora.com FB login
https://www.espn.com/login/ FB login
https://www.etsy.com/signin FB login
Retest these issues about embedded tweets, they should still work.
Image from facebook/twitter not loading browser-laptop#2014
Embeded Tweets browser-laptop#1208
Test that Google login only works when the option is on for https://pinterest.com/login/
You will need to reload between login attempts after the setting is changed.
You may need to click the login button twice, if so the issue is not related to this ticket but can be posted.
The text was updated successfully, but these errors were encountered: