Add tags to optional filters #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
commented
Mar 7, 2019
| @@||pbs.twimg.com/$tag=twitter-embeds | ||
| ||cdn.syndication.twimg.com/$tag=twitter-embeds | ||
| @@||cdn.syndication.twimg.com/$tag=twitter-embeds | ||
| ! LinkedIn in embed |
There was a problem hiding this comment.
These LinkedIn tagged filters are new below this line.
bbondy
commented
Mar 7, 2019
| ||sp1.nypost.com$third-party | ||
| ||sp.nasdaq.com$third-party | ||
| ||lesechos.fr/xtcore.js$third-party | ||
| ||y8.com/js/sdkloader/outstream.js$third-party |
There was a problem hiding this comment.
This whole block is just moved from the bottom above the tagged optional filters.
bbondy
force-pushed
the
tags-for-optional-filters
branch
from
d90dce5
to
7f8f73b
Compare
This was referenced Mar 11, 2019
bbondy
added a commit
that referenced
this pull request
Mar 14, 2019
…ilters"" This reverts commit 8e01146.
This was referenced Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tags to the optional filters.
A tagged filter is only matched if the ad_block_client has called addTag with that tag value.
We have preferences now in brave-core to add those tags.