Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit brave usage of ExecuteJavaScriptInIsolatedWorld() & ExecuteScript*() #34915

Open
atuchin-m opened this issue Dec 15, 2023 · 1 comment
Open
Assignees
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop perf

Comments

@atuchin-m
Copy link
Contributor

We need to investigate how it could affect every day browser usage performance.
Methods:
browser process: ExecuteJavaScriptInIsolatedWorld() and ExecuteJavaScriptForTests()
renderer: ExecuteScript[InIsolatedWorld](), RequestExecuteScript()

image image image
@atuchin-m atuchin-m added perf dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 15, 2023
@atuchin-m atuchin-m self-assigned this Dec 15, 2023
@atuchin-m
Copy link
Contributor Author

A list of related issues:

  1. ads new XMLSerializer().serializeToString(document) inject: [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match view-through or click-through conversions #38497. The previous attempt: [ads] Optimize ads tab helper innerText/HTML performance #34919
  2. braveEthereum [perf] braveEthereum and braveSolana inject on an empty profile #35237
  3. braveSolana inject (the similar to braveEthereum).
  4. content_picker Brave extension inject: Don't inject content picker on pages by default #37841
  5. playlist mutation observer inject for audio/video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop perf
Projects
Status: To do
Development

No branches or pull requests

1 participant