Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inject content picker on pages by default #37841

Closed
pes10k opened this issue Apr 24, 2024 · 0 comments · Fixed by brave/brave-core#25330
Closed

Don't inject content picker on pages by default #37841

pes10k opened this issue Apr 24, 2024 · 0 comments · Fixed by brave/brave-core#25330
Assignees
Labels
feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/Yes release-notes/exclude
Milestone

Comments

@pes10k
Copy link
Contributor

pes10k commented Apr 24, 2024

At least from doing some pagegraph tests, i see we’re loading ./components/brave_extension/extension/brave_extension/content_element_picker.ts [1] on every page load (along with the source map).

Its not enormous but its not nothing. Maybe a small perf benefit to remove that? (since enabling the element picker is a very very rare thing)

Like @atuchin-m suggested on Slack, would be best to only load/inject this when the user asks for the element picker

1: https://github.com/brave/brave-core/blob/5718b3ac479e473a049ae346577709e90fb2ae3c/components/brave_extension/extension/brave_extension/content_element_picker.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/Yes release-notes/exclude
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants