Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing using background page in content_picker #40696

Closed
atuchin-m opened this issue Aug 27, 2024 · 3 comments · Fixed by brave/brave-core#25358
Closed

Removing using background page in content_picker #40696

atuchin-m opened this issue Aug 27, 2024 · 3 comments · Fixed by brave/brave-core#25358
Assignees
@atuchin-m
Labels
dev-concern feature/shields The overall Shields feature in Brave. OS/Desktop QA/No release-notes/exclude
Milestone
1.71.x - Release

Comments

@atuchin-m
Copy link
Contributor

Description

It's a part of the work to remove Brave Extension background page: #39610
The plan is reimplement a part of content picker to get rid off a communication with background page.
@atuchin-m atuchin-m added the feature/shields The overall Shields feature in Brave. label Aug 27, 2024
@atuchin-m atuchin-m self-assigned this Aug 27, 2024
@atuchin-m
Copy link
Contributor Author

The previous task: #37841

@atuchin-m atuchin-m mentioned this issue Aug 28, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 2, 2024
@atuchin-m atuchin-m mentioned this issue Sep 3, 2024
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Sep 19, 2024 •
edited
Loading

@atuchin-m seems like this one can be changed to QA/No since the test plan is the same as #40821 which is being requested for uplift via brave/brave-core#25574. Does that sound good?

Adding QA/Blocked until the above is sorted out.

@atuchin-m
Copy link
Contributor Author

@LaurenWags LGTM

@atuchin-m atuchin-m added QA/No and removed QA/Yes labels Sep 20, 2024
@LaurenWags LaurenWags mentioned this issue Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atuchin-m atuchin-m

Labels
dev-concern feature/shields The overall Shields feature in Brave. OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Content Picker refactoring into a single script brave/brave-core
6 participants
@kjozwiak @rebron @LaurenWags @brave-builds @atuchin-m and others