Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content picker native inject (uplift to 1.71.x) #25574

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Content picker native inject (uplift to 1.71.x) #25574

merged 1 commit into from
Sep 23, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 16, 2024 •
edited by kjozwiak
Loading

Uplift of #25411
Resolves brave/brave-browser#40821

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 16, 2024 09:48
@brave-builds brave-builds added this to the 1.71.x - Beta milestone Sep 16, 2024
@brave-builds brave-builds self-assigned this Sep 16, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 16, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@LaurenWags LaurenWags mentioned this pull request Sep 19, 2024
Closed
kjozwiak
kjozwiak approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.71.x approved 👍 QA has verified the PR on Nightly on 1.71.x as per #25411 (comment).

@kjozwiak kjozwiak merged commit f1a3909 into 1.71.x Sep 23, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr25411_content-picker-native-inject_1.71.x branch September 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak