Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use api slice for async swap logic #35027

Closed
josheleonard opened this issue Dec 22, 2023 · 1 comment · Fixed by brave/brave-core#21454
Closed

use api slice for async swap logic #35027

josheleonard opened this issue Dec 22, 2023 · 1 comment · Fixed by brave/brave-core#21454
Assignees
@josheleonard
Labels
dev-concern dev-experience feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.63.x - Release

Comments

@josheleonard
Copy link

Description

Refactor frontend usage of the swap service to utilize the api slice instead of the lib context
@josheleonard josheleonard self-assigned this Dec 22, 2023
@josheleonard josheleonard mentioned this issue Dec 22, 2023
Merged
25 tasks
@jamesmudgett jamesmudgett moved this to In Review in Web3 Dec 22, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Dec 29, 2023
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 29, 2023
@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2024

Verification passed on

Brave 1.63.146 Chromium: 121.0.6167.139 (Official Build) beta (64-bit)
Revision cb9ee9c98182a64716e4237bf1202f1aec3bcff8
OS Windows 11 Version 23H2 (Build 22631.3007)
  • Verified steps from brave/brave-core#21454
  • Verified EVM/Solana swaps works as expected without any regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
dev-concern dev-experience feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.63.x - Release
Development

Successfully merging a pull request may close this issue.

chore: use api endpoints for swap logic brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds