Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use api endpoints for swap logic #21454

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Dec 22, 2023

Resolves brave/brave-browser#35027

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

EVM and Solana swaps should continue to work without regressions

@josheleonard josheleonard self-assigned this Dec 22, 2023
@josheleonard josheleonard requested a review from a team as a code owner December 22, 2023 12:49
@josheleonard josheleonard changed the title Chore use api endpoints for swap logic Chore: use api endpoints for swap logic Dec 22, 2023
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Dec 22, 2023
@josheleonard josheleonard changed the title Chore: use api endpoints for swap logic chore: use api endpoints for swap logic Dec 22, 2023
}
}),

generateSwapQuote: mutation<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any good reason for not sticking with the existing convention of using the get* prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the generate* prefix instead of get* for these endpoints to help show that these are mutations instead of queries. I used mutations so that the results can be recomputed when called again instead of returning a cached value. Please let me know if we can use queries/cached values instead

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@josheleonard josheleonard merged commit 6e1a0a2 into master Dec 29, 2023
19 checks passed
@josheleonard josheleonard deleted the chore--use-api-endpoints-for-swap-logic branch December 29, 2023 16:58
@github-actions github-actions bot added this to the 1.63.x - Nightly milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use api slice for async swap logic
3 participants