Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when trying to open brave://sync in Guest Window #3522

Closed
btlechowski opened this issue Feb 28, 2019 · 4 comments
Closed

Crash when trying to open brave://sync in Guest Window #3522

btlechowski opened this issue Feb 28, 2019 · 4 comments

Comments

@btlechowski
Copy link

Follow up from #2852

Steps to Reproduce

  1. Open Guest Window
  2. Open brave://sync

Actual result:

Crash

Expected result:

No crash

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.62.8 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312
Brave 0.61.39 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Related issues: #3003.

@simonhong I have not seen this issue reported for Guest Window.

cc @brave/legacy_qa

@simonhong
Copy link
Member

@btlechowski This was also fixed by brave/brave-core#1704.
That PR handles crash on Tor and Guest both.

@kjozwiak
Copy link
Member

@btlechowski mind taking a look and seeing if it's an issue on 0.63.x. Might have to build from source as we don't have nightly builds yet. If you would like, I can check on macOS as I have a recent build already 👍

@btlechowski btlechowski added this to the 0.63.x - Dev milestone Mar 13, 2019
@btlechowski
Copy link
Author

Based on #3522 (comment) the issue was fixed in brave/brave-core#1704

@btlechowski
Copy link
Author

btlechowski commented Mar 13, 2019

Verification passed on

Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from the description
image

Verification passed on

Brave 0.63.7 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
  • Verified the STR mentioned in the description
    image

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.63.9 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Screen Shot 2019-03-15 at 12 29 28 AM

  • ensured that both chrome://sync and brave://sync didn't cause any crashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment