Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave:// changes to chrome:// in URL bar #3545

Closed
LaurenWags opened this issue Mar 1, 2019 · 4 comments
Closed

brave:// changes to chrome:// in URL bar #3545

LaurenWags opened this issue Mar 1, 2019 · 4 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 1, 2019

Description

Only seems to affect 0.61.x.

If you navigate to a page like brave://version and then double click in the URL bar (say you want to change version to settings), you'll see that the brave:// part changes to chrome://.

Steps to Reproduce

  1. Open brave://version and let the page load.
  2. Double click in URL bar

Actual result:

brave:// changes to chrome://
urlbar061x

Expected result:

Should stay brave://
urlbar060x

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

Reproducible on current release: no, does not reproduce on 0.60.47

  • Does it reproduce on brave-browser dev/beta builds? only beta 0.61.41.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Does not reproduce on Dev version 0.62.11
urlbar062x

@WhiteR4bbitt
Copy link

My address bar does not update to chrome, but this may be in the same realm of brave:// urls. Let me know if this should be in its own issue.

I am on 0.60.47, not sure if this is similar enough to be part of this issue but this is what I notice when on brave://about. All the URLS highlighted show chrome at the bottom, but will click through to brave://<item>
image

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 5, 2019
@modelmat
Copy link

Additionally pages such as brave://invalid show a chrome://invalid page.
image
and the tab shows:
image

@bsclifton
Copy link
Member

bsclifton commented Oct 9, 2019

@LaurenWags I think this has been fixed ("Works for me™"), can you confirm?

@LaurenWags
Copy link
Member Author

@bsclifton yep, appears to be working on the following versions:

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.71.89 Chromium: 77.0.3865.90 (Official Build) dev (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.72.83 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants