Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement additional ad event confirmations #3587

Closed
jsecretan opened this issue Mar 5, 2019 · 2 comments · Fixed by brave/brave-core#1890
Closed

Implement additional ad event confirmations #3587

jsecretan opened this issue Mar 5, 2019 · 2 comments · Fixed by brave/brave-core#1890

Comments

@jsecretan
Copy link

jsecretan commented Mar 5, 2019

Test plan

See brave/brave-core#1890

Description

The current implementation of ad confirmations sends those secure confirmations in the event of an ad being viewed (Confirmation type: view). However, to complete our requirements for campaign reporting, we need to implement the following additional confirmations attached to the following events:

  • Confirmation upon clicking through on an ad (Confirmation type: click)
  • Confirmation for when an ad is dismissed (X'ed out) (Confirmation type: dismiss)
  • Following a click, a confirmation that is sent after the user has the landing page open for 10 seconds (Confirmation type: landed)
@tmancey tmancey added the QA/Yes label Mar 7, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 11, 2019
@NejcZdovc NejcZdovc added this to the 0.64.x - Nightly milestone Mar 12, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 12, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 13, 2019
@bsclifton
Copy link
Member

Updated milestone after brave/brave-core#1923 was merged

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 5, 2019

Verification passed on

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523
  • Timed out ads After getting ads notification waited for around 2mins until ads notification vanishes without any user interaction. Verified the confirmations.json file after notification got vanished.

clicked, viewed, dismissed and landed Ads are redeemed on Ads Serve and timed out Ads are not redeemed on Ads Server.

image

Verification passed on both

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux
 "transactions": [
      {
        "confirmation_type": "view",
        "estimated_redemption_value": 0.05,
        "timestamp_in_seconds": "13198861161"
      },
      {
        "confirmation_type": "click",
        "estimated_redemption_value": 0.0,
        "timestamp_in_seconds": "13198861169"
      },
      {
        "confirmation_type": "landed",
        "estimated_redemption_value": 0.0,
        "timestamp_in_seconds": "13198865269"
      },
      {
        "confirmation_type": "dismiss",
        "estimated_redemption_value": 0.0,
        "timestamp_in_seconds": "13198950367"
      }
    ]
  },
Brave 0.64.47 Chromium: 74.0.3729.61 (Official Build) dev(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux
"transactions": [
      {
        "confirmation_type": "view",
        "estimated_redemption_value": 0.05,
        "timestamp_in_seconds": "13198596718"
      },
      {
        "confirmation_type": "click",
        "estimated_redemption_value": 0.0,
        "timestamp_in_seconds": "13198596731"
      },
      {
        "confirmation_type": "landed",
        "estimated_redemption_value": 0.0,
        "timestamp_in_seconds": "13198596740"
      },
      {
        "confirmation_type": "dismiss",
        "estimated_redemption_value": 0.0,
        "timestamp_in_seconds": "13199902904"
      }
    ]
  },

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Screen Shot 2019-04-17 at 12 39 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment