Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bat-native-ads to brave-core #3599

Closed
tmancey opened this issue Mar 6, 2019 · 2 comments · Fixed by brave/brave-core#1871
Closed

Migrate bat-native-ads to brave-core #3599

tmancey opened this issue Mar 6, 2019 · 2 comments · Fixed by brave/brave-core#1871

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 6, 2019

Test plan

See brave/brave-core#1871

@tmancey
Copy link
Contributor Author

tmancey commented Apr 16, 2019

Test Plan: Confirm Ads work as expected, however this has been tested in other tickets so how much needs testing would depend on other tickets

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 16, 2019

Verification passed on

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Windows 10 OS Build 17134.523

Verification passed on both

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux
Brave 0.64.47 Chromium: 74.0.3729.61 (Official Build) dev(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux
  • Verified View, Click, Landed and Dismiss transactions are logged in confirmations.json
  • Verefied the total ads viewed matches the count in rewards and the payout for ads matches the transaction type

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X
  • Ran thru Confirmations Test Plan (separate google doc)
  • Verified View, Click, Landed and Dismiss transactions are logged in confirmations.json
  • Verified the total ads viewed matches the count in rewards and the payout for ads matches the transaction type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment