Buy/Send/Swap not opening from Asset Details

[StephenHeaps]

Description:

Buy, send and swap are not opening for some assets when tapped in Asset Details. The bug seems to occur on any asset with no account balance.

Steps to Reproduce

1. Open Wallet
2. Scroll Portfolio to find ETH on Optimism.
   • Seems to occur on any asset where user does not have any account balance
3. Tap 'Buy'
4. Observe buy does not open
   • Buy/send/swap do not open either
   • Some other assets do open as expected. Needs investigation.

Actual result:

Asset.Details.MP4

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced with ETH on Optimism, not all assets failing to open.

Brave Version:

v1.62 App Store

• Can you reproduce this issue with the most recent build from TestFlight?
• Can you reproduce this issue with the previous version of the current build from TestFlight?
• Can you reproduce this issue with the current build from AppStore?

Device details:

iPhone 14 Pro iOS 17.3.1

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

Community report:
https://community.brave.com/t/i-cannot-send-or-swap-crypto/532738/3

[kjozwiak]

Closing as the above landed in master via brave/brave-core#22229.

[kjozwiak]

The above requires 1.63.164 or higher for 1.63.x verification 👍 @srirambv @StephenHeaps assuming this is a regression hence being uplifted into 1.63.x? Should we add the release-notes/include label?

[StephenHeaps]

@kjozwiak yes regression, I think good to include in release notes as it was reported by community.

[kjozwiak]

Labelling as QA/No & release-notes/exclude as per brave/brave-ios#8776 (comment).