Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet/iOS] Fix #36266: Buy/Send/Swap buttons not opening from Asset Details #22229

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Feb 21, 2024

Resolves brave/brave-browser#36266

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to an asset details that no wallet account has balance of it
  2. click Buy/Send/Swap button
  3. button should open correct screen for users to buy/send/swap

@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 21, 2024
@nuo-xu nuo-xu self-assigned this Feb 21, 2024
@nuo-xu nuo-xu requested a review from a team as a code owner February 21, 2024 20:08
Copy link
Collaborator

@StephenHeaps StephenHeaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just variable name to fix 🙂

@srirambv
Copy link
Contributor

Verification passed on iPad with iOS 16.7.5 running 1.65(30) nightly build

  • Verified steps from pr description
  • Verified Buy/Send/Swap buttons work as expected and loads correct screen when opened from asset details screen
22229.MP4

kjozwiak pushed a commit that referenced this pull request Feb 26, 2024
… Details (uplift to 1.64.x) (#22247)

Uplift of #22229 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Feb 26, 2024
… Details (uplift to 1.63.x) (#22248)

Uplift of #22229 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buy/Send/Swap not opening from Asset Details
3 participants