Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Hide/Unhide NFTs #36754

Closed
srirambv opened this issue Mar 13, 2024 · 3 comments · Fixed by brave/brave-core#24786
Closed

Unable to Hide/Unhide NFTs #36754

srirambv opened this issue Mar 13, 2024 · 3 comments · Fixed by brave/brave-core#24786
Assignees
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 13, 2024

Description

Unable to Hide/Unhide NFTs

Steps to Reproduce

  1. Restore wallet with NFTs
  2. Go to hidden NFTs
  3. Some of the Spam NFTs can't be marked as Not Junk
  4. Unhide a few Spam NFTs to list it in collected
  5. Go back to Collected NFTs
  6. Click on more menu and Hide NFT
  7. Doesn't hide the NFT
  8. Click on menu again shows Unhide button

Actual result:

brave_9ow74hSsFX.mp4
brave_TtpTXZK26l.mp4

Expected result:

Should be able to Hide/Unhide NFTs

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.64.102 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
Revision c9343c77bd5dee3524fc45f89721ce0bf4c09b8d
OS Windows 11 Version 23H2 (Build 22631.3155)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam

@kjozwiak
Copy link
Member

Labelled as QA/Blocked as this will be verified via 1.68.x once brave/brave-core#24802 is uplifted into 1.68.x.

@kjozwiak
Copy link
Member

The above requires 1.68.134 or higher for 1.68.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.68.134 Chromium: 127.0.6533.88 (Official Build) (64-bit)
Revision 71f3c9cc80f92022892bbf6a22c0450ea056ade4
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from issue description
  • Verified able to mark NFTs as Not junk
  • Verified able to mark collected NFT as Junk
  • Verified able to hide/unhide NFTs successfully
36754.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants