Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): do not remove NFT when marked as junk (uplift to 1.68.x) #24802

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix(wallet): do not remove NFT when marked as junk (uplift to 1.68.x) #24802

merged 1 commit into from
Jul 30, 2024

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Jul 23, 2024 •
edited by kjozwiak
Loading

Uplift of #24786
Resolves brave/brave-browser#36754

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@josheleonard josheleonard self-assigned this Jul 23, 2024
@josheleonard josheleonard requested a review from a team as a code owner July 23, 2024 15:23
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jul 23, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak mentioned this pull request Jul 23, 2024
Closed
@kjozwiak kjozwiak added this to the 1.68.x - Release #4 milestone Jul 30, 2024
kjozwiak
kjozwiak approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.68,x approved 👍 QA has verified the PR on Nightly using 1.70.x as per #24786 (comment).

@kjozwiak kjozwiak merged commit bde1eb6 into 1.68.x Jul 30, 2024
15 checks passed
@kjozwiak kjozwiak deleted the fix--wallet--do-not-remove-token-when-marking-as-junk-1.68.x branch July 30, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@josheleonard josheleonard

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Milestone
1.68.x - Release #4
Development

Successfully merging this pull request may close these issues.
3 participants
@josheleonard @brave-builds @kjozwiak