Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Now button is only clickable when tapping on the text/string (entire button should be clickable) #36787

Closed
kjozwiak opened this issue Mar 14, 2024 · 2 comments · Fixed by brave/brave-core#22578

Comments

@kjozwiak
Copy link
Member

Description:

Currently only clicking on the Upgrade Now text registers/initiates a click event via the Leo Premium paywall. If you click anywhere else on the button that's not the text, nothing happens. Users might think that the button is broken if they don't click on the text which could lead to users not purchasing/moving forward.

Steps to Reproduce

  1. install 1.63.173 Chromium: 122.0.6261.111 via TF
  2. go into Hamburger Menu -> Settings -> Leo -> Go Premium
  3. attempt to click anywhere on the button that's not the text/string (nothing happens)

Actual result:

IMG_0056

Expected result:

Users should be able to tap anywhere within the Upgrade Now button to initiate a click.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible when using the STR/Cases outlined above.

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? N/A (1.63.x hasn't been released with Leo)

Device details:

1.63.173 Chromium: 122.0.6261.111 (Official Build) unknown (64-bit) 
--- | ---
Revision | 77ac6bd3b328...
OS | iOS 17.4 via `iPhone 11`

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Mobile Safari? N/A

Additional Information

@kjozwiak
Copy link
Member Author

The above requires 1.63.177 or higher for 1.63.x verification 👍

@kjozwiak
Copy link
Member Author

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.177 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | f43e1b1dc6dc...
OS | iOS

Using the STR/Cases outlined via #36787 (comment), ensured that the entire Upgrade button worked under Leo Premium model as per the following:

RPReplay_Final1710522883.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants