Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brave Leo deep link #36800

Closed
iccub opened this issue Mar 14, 2024 · 2 comments · Fixed by brave/brave-core#22598
Closed

Add Brave Leo deep link #36800

iccub opened this issue Mar 14, 2024 · 2 comments · Fixed by brave/brave-core#22598

Comments

@iccub
Copy link

iccub commented Mar 14, 2024

This allows us to use such link for the in-app event or in other places.

Test plan:

  1. Use prod channel
  2. Copy brave://deep-link?path=brave_leo to notes.app
  3. Tap on it
  4. It should open the browser and open Leo

This will not work if onboarding has not completed. It may not work for few other edge cases if other screens are open, nothing to worry about.

@iccub iccub added OS/iOS Fixes related to iOS browser functionality browser-ai QA/Yes release-notes/exclude labels Mar 14, 2024
iccub added a commit to brave/brave-core that referenced this issue Mar 14, 2024
iccub added a commit to brave/brave-core that referenced this issue Mar 14, 2024
iccub added a commit to brave/brave-core that referenced this issue Mar 14, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 14, 2024
kjozwiak pushed a commit to brave/brave-core that referenced this issue Mar 15, 2024
@kjozwiak
Copy link
Member

The above requires 1.63.177 or higher for 1.63.x verification 👍

@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.177 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | f43e1b1dc6dc...
OS | iOS

Using the STR/Cases outlined via #36800 (comment), that clicking on the deep link opened Leo without any issues as per the following:

RPReplay_Final1710523752.MP4

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.177 Chromium: 122.0.6261.128 (Official Build)unknown (64-bit)
-- | --
Revision | f43e1b1dc6dce1f4139b11ae15ce93c4dbc0ea42
OS | iOS

Using the STR/Cases outlined via #36800 (comment), that clicking on the deep link opened Leo without any issues as per the following:

RPReplay_Final1710528588.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants