Default modal for new conversations reverting to Mixtral after restarting Brave - Follow up to #36816

[kjozwiak]

Description:

Looks like #36816 fixed the issue re: the saving/retaining the users choice re: which modal will be used as the default via the Advanced Settings, but there's still a bug when restarting Brave. Once a user has restarted Brave, Mixtral will once again be selected as the default model even though a user picked either Claude or Lama.

Steps to Reproduce

1. install 1.66.10 Chromium: 123.0.6312.46 via TF
2. once you've gone through onboarding/open Leo via the Hamburger Menu and run through the onboarding/T&S
3. click on Hamburger Menu -> Settings -> Leo and tap on default modal for new conversations
4. pick either Claude Instant or Llama 2 13b and close the Settings page
5. restart Brave and you'll notice that Mixtral is once again selected as the default model

Actual result:

RPReplay_Final1710717404.MP4

Expected result:

Once a user selects a new default model via default modal for new conversations in the Advanced Settings, we should respect the users choice and retain the choice even if the user restarts Brave.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the STR/Cases outlined above.

Brave Version:

1.66.10 Chromium: 123.0.6312.46 (Official Build) unknown (64-bit) 
--- | ---
Revision | 741e5a4ef519...
OS | iOS

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? No (introduced via [iOS] - Leo QA Iteration 3 brave-core#22627 which was fixing default modal for new conversations not respecting user choice and always reverting to Mixtral #36816)
• Can you reproduce this issue with the current build from AppStore? N/A (1.63.x still hasn't released for iOS)

Device details:

• iPhone 11 running iOS 17.4

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Is the issue reproducible on the latest version of Mobile Safari? N/A

Additional Information

[kjozwiak]

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.179 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | 347b176a5cd6...
OS | iOS

Quick Note: With the following STR/Cases, it's a combination of #36816 (comment) & #36886 (comment).

Test Case #1 - Changing default Leo model within the same session - PASSED

• ensured that switching the default Leo modal via Hamburger Menu -> Settings -> Leo retained the users selection/choice
  • also ensured that switching the Leo panel -> Advanced Settings retained the users selection/choice
• ensured that selecting different modals via the Leo panel only changes the modal for that specific conversation/instance

RPReplay_Final1710818808.MP4

Test Case #2 - Changing default Leo model within then restarting Brave - PASSED

Using the STR/Cases outlined via #36886 (comment), ensured that restarting Brave retains the default model as per the following:

RPReplay_Final1710818948.MP4

---

Verification PASSED on iPad Air (3rd Gen) running iOS 17.4 using the following build(s):

1.63.179 Chromium: 122.0.6261.128 (Official Build)unknown (64-bit)
-- | --
Revision | 347b176a5cd613160ea9e98b3a72274ddd8de653

Quick Note: With the following STR/Cases, it's a combination of #36816 (comment) & #36886 (comment).

Test Case #1 - Changing default Leo model within the same session - PASSED

• ensured that switching the default Leo modal via Hamburger Menu -> Settings -> Leo retained the users selection/choice
  • also ensured that switching the Leo panel -> Advanced Settings retained the users selection/choice
• ensured that selecting different modals via the Leo panel only changes the modal for that specific conversation/instance

Example --> https://youtu.be/JNAEc5fhH9w

Test Case #2 - Changing default Leo model within then restarting Brave - PASSED

Using the STR/Cases outlined via #36886 (comment), ensured that restarting Brave retains the default model as per the following:

Example --> https://youtu.be/m_HzpWtr0nE