Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change maximum Ads per day to 20 for Desktop and 12 for Android #3849

Closed
tmancey opened this issue Mar 22, 2019 · 2 comments · Fixed by brave/brave-core#2030
Closed

Change maximum Ads per day to 20 for Desktop and 12 for Android #3849

tmancey opened this issue Mar 22, 2019 · 2 comments · Fixed by brave/brave-core#2030
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 22, 2019 •
edited
Loading

Change maximum Ads per day to 20 for Desktop and 12 for Android
@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 22, 2019
@tmancey tmancey self-assigned this Mar 22, 2019
@tmancey tmancey mentioned this issue Mar 22, 2019
Merged
19 tasks
@tmancey tmancey modified the milestones: 0.64.x - Dev, 0.65.x - Nightly Apr 1, 2019
@jsecretan jsecretan added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 4, 2019
@tmancey tmancey changed the title Change maximum Ads per day to 20 Change maximum Ads per day to 20 for Desktop and 12 for Android Apr 8, 2019
tmancey added a commit to brave/brave-core that referenced this issue Apr 9, 2019
@tmancey
Change maximum Ads per day to 12 for Android and 20 for Desktop
89e368d 
fixes brave/brave-browser#3849
This was referenced Apr 9, 2019
Merged
Merged
pilgrim-brave pushed a commit to brave/brave-core that referenced this issue Apr 16, 2019
@tmancey @pilgrim-brave
Change maximum Ads per day to 12 for Android and 20 for Desktop
a50b923 
fixes brave/brave-browser#3849
tmancey added a commit to brave/brave-core that referenced this issue Apr 16, 2019
@tmancey
Change maximum Ads per day to 12 for Android and 20 for Desktop
76ca054 
fixes brave/brave-browser#3849
tmancey added a commit to brave/brave-core that referenced this issue Apr 16, 2019
@tmancey
Change maximum Ads per day to 12 for Android and 20 for Desktop
f4b5299 
fixes brave/brave-browser#3849
@LaurenWags
Copy link
Member

Logged https://github.com/brave/browser-android-tabs/issues/1485 in Android repo to track testing Android part.

@kjozwiak kjozwiak mentioned this issue Apr 23, 2019
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Apr 23, 2019 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave 0.63.47 Chromium: 74.0.3729.108 (Official Build) (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X

Verification passed on

Brave 0.63.48 Chromium: 74.0.3729.108 (Official Build) (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Linux

Verification passed on

Brave 0.63.48 Chromium: 74.0.3729.108 (Official Build) (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Windows 10 OS Build 17134.523

@kjozwiak kjozwiak mentioned this issue Dec 24, 2019
Closed
97 tasks
@LaurenWags LaurenWags mentioned this issue Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Change maximum Ads per day to 12 for Android and 20 for Desktop brave/brave-core
6 participants
@jsecretan @tmancey @kjozwiak @srirambv @LaurenWags @GeetaSarvadnya