Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Rewards is set to OFF, click on Enable Brave Rewards does nothing #3851

Closed
GeetaSarvadnya opened this issue Mar 22, 2019 · 4 comments · Fixed by brave/brave-core#2051
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 22, 2019

Description

When Rewards is set to OFF, click on Enable Brave Rewards does nothing

Steps to Reproduce

  1. Clean profile 0.64.8
  2. Enable rewards
  3. Turn off Brave Rewards switch in brave://rewards page
  4. Open BR panel and click on Enable Brave Rewards button

Actual result:

Click on Enable Brave Rewards does nothing

Expected result:

Click on Enable Brave Rewards should enable the rewards

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.64.8 Chromium: 73.0.3683.75 (Official Build) nightly (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Reproducible on current release: No

  • Does it reproduce on brave-browser dev/beta builds? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

@jasonrsadler
Copy link

cc @ryanml
@GeetaSarvadnya I believe expected functionality is the BR panel 'Enable' simply navigates to Rewards page to allow user to enable on the Rewards page

@ryanml
Copy link
Contributor

ryanml commented Mar 24, 2019

@NejcZdovc @jenn-rhim are you fine with current behavior of navigation or would you like the button to turn on Rewards directly?

@NejcZdovc
Copy link
Contributor

@ryanml button should enable rewards directly

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented May 4, 2019

Verification passed on

Brave 0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Windows 10 OS Build 17134.523
  • Verified the STR mentioned in the description

Verification passed on

Brave 0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Linux
  • Verified the STR mentioned in the description

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment