Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create whitelist for using Brave UA #39

Closed
bbondy opened this issue Dec 28, 2017 · 4 comments
Closed

Create whitelist for using Brave UA #39

bbondy opened this issue Dec 28, 2017 · 4 comments
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Dec 28, 2017

For reference:
https://github.com/brave/browser-android-tabs/commit/55fda525fd64a1f6539ea20b8a0a0ebe6a573533
@bbondy bbondy added this to the Milestone 1: To be able to open source the repo milestone Dec 28, 2017
@bridiver
Copy link
Contributor

this is what we do in muon

web_contents()->SetUserAgentOverride(user_agent);
    params.override_user_agent =
        content::NavigationController::UA_OVERRIDE_TRUE;

@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Milestone 2: To offer Installable and updatable builds Mar 19, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #39 from brave/web-ui-cleanup
94fb5d2 
Update new-tab stats as stats change and cleanup
@bbondy
Copy link
Member Author

bbondy commented Jun 6, 2018

This is already done.

@bbondy bbondy closed this as completed Jun 6, 2018
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@bbondy
Copy link
Member Author

bbondy commented Aug 18, 2018 •
edited
Loading

QA notes: You'll need to use dev tools for this in the network tab.
Also document.referrer

@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018 •
edited by kjozwiak
Loading

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

image

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

image

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
  • Verified on DDG, Adobe, Netflix & Brave. Ensured that we overwrite the default UA in those instances.

@bbondy bbondy added the QA/Yes label Sep 27, 2018
@iefremov iefremov mentioned this issue Nov 27, 2020
Closed
@bridiver bridiver mentioned this issue Mar 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
5 participants
@bridiver @bbondy @kjozwiak @srirambv @GeetaSarvadnya