Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookie page from settings: brave://settings/cookies/detail?site=XYZ #39033

Closed
3 of 6 tasks
ShivanKaul opened this issue Jun 14, 2024 · 5 comments · Fixed by brave/brave-core#24256
Closed
3 of 6 tasks

Comments

@ShivanKaul
Copy link
Collaborator

Description

Upstream Chromium has removed the cookie page which let you view all cookies for a site. We brought it back briefly by disabling the kDeprecateCookiesTreeModel flag in #37030, but CR 125 immediately removed that flag which caused the page to be broken again.

Note that users can already view cookies by going to a page and seeing/editing cookies via DevTools => Application => Cookies. That workaround doesn't address the use-case of seeing cookies for a page without actually visiting it, but if we want to address that use-case it needs to be a whole new feature; patching and tweaking upstream code is too brittle at this point. In the meantime this page is actively broken in Release and we should fix ASAP: #38578.

Steps to reproduce

  1. Go to brave://settings/content/all
  2. Select a site e.g. github.com (brave://settings/content/siteDetails?site=https%3A%2F%2Fgithub.com%2F)
  3. Go to Cookies and Site Data (brave://settings/cookies/detail?site=github.com)

Actual result

image

image

Expected result

  1. There should be no Cookies and Site Data under the Site Details page for a site.
  2. brave://settings/cookies/detail?site=github.com page should not exist.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.66.118 Chromium: 125.0.6422.147 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@emerick
Copy link
Contributor

emerick commented Jun 25, 2024

brave/brave-core#17746 would essentially need to be reverted (we'd have to be careful of course; it's probably not quite a direct revert).

@iefremov
Copy link
Contributor

There is a PR by a volunteer, can somebody review? @emerick @petemill brave/brave-core#24256

@kjozwiak
Copy link
Member

kjozwiak commented Jul 2, 2024

The above requires 1.67.129 or higher for 1.67.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.67.131 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | e3ca6babc88232bab25830c09164a034adae83bd
OS | Windows 10 Version 22H2 (Build 19045.4529)

Reproduced the issue using 1.67.123 Chromium: 126.0.6478.126 and STR from #39033 (comment). The "Cookies and Site Data" option was present and when clicked, opened a blank page that did not show data:

Example Example
image image

Confirmed with 1.67.131 Chromium: 126.0.6478.126, the "Cookies and Site Data" option was removed from the site specific page as expected:

image

@wilrodx

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants