-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cookie page from settings: brave://settings/cookies/detail?site=XYZ #39033
Comments
brave/brave-core#17746 would essentially need to be reverted (we'd have to be careful of course; it's probably not quite a direct revert). |
There is a PR by a volunteer, can somebody review? @emerick @petemill brave/brave-core#24256 |
The above requires |
Verification PASSED on
Reproduced the issue using
Confirmed with |
Description
Upstream Chromium has removed the cookie page which let you view all cookies for a site. We brought it back briefly by disabling the
kDeprecateCookiesTreeModel
flag in #37030, but CR 125 immediately removed that flag which caused the page to be broken again.Note that users can already view cookies by going to a page and seeing/editing cookies via DevTools => Application => Cookies. That workaround doesn't address the use-case of seeing cookies for a page without actually visiting it, but if we want to address that use-case it needs to be a whole new feature; patching and tweaking upstream code is too brittle at this point. In the meantime this page is actively broken in Release and we should fix ASAP: #38578.
Steps to reproduce
Cookies and Site Data
(brave://settings/cookies/detail?site=github.com)Actual result
Expected result
Cookies and Site Data
under the Site Details page for a site.Reproduces how often
Easily reproduced
Brave version (brave://version info)
1.66.118 Chromium: 125.0.6422.147 (Official Build) (arm64)
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: