Brave crashes when trying to migrate from v3 to v5+ publisher_info_db version

[jasonrsadler]

Description

Steps to Reproduce

1. Open Brave with a v3 publisher_info_db version database
2. Go to rewards page or open rewards panel
3. Brave will attempt to upgrade the database

Actual result:

Fatal crash:

[2614:44291:0327/133243.040948:ERROR:database.cc(1713)] publisher_info_db sqlite error 1, errno 0: table activity_info has no column named month, sql: PRAGMA foreign_keys=off;INSERT INTO activity_info (publisher_id, duration, score, percent, weight, month, year, reconcile_stamp) SELECT publisher_id, duration, score, percent, weight, month, year, reconcile_stamp FROM activity_info_old;UPDATE activity_info SET visits=5;DROP TABLE activity_info_old;PRAGMA foreign_keys=on;
[2614:44291:0327/133243.041042:FATAL:database.cc(1726)] table activity_info has no column named month

Expected result:

The database upgrades successfully

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.64.20 Chromium: 74.0.3729.22 (Developer Build) (64-bit)
Revision	d183f516540c1a0c21310ced2e2170a534bca5a5-refs/branch-heads/3729@{#254}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  unknown

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

v3 database to test
publisher_info_db.zip

[jasonrsadler]

Caused by v4 upgrade after v3 has performed. v4 tries to select a month and year column that doesn't exist.

[btlechowski]

Verification passed on

Brave	0.63.42 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision	fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS	Ubuntu 18.04 LTS

Used test plan from brave/brave-core#2122

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave	0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision	fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS	Mac OS X

• Went through the test cases outlined under Browser no longer crashes when upgrading from a v3 to a v5+ database brave-core#2122
• ensured that v2 was upgraded to v6 using the meta table under publisher_info_db
• ensured that v3 was upgraded to v6 using the meta table under publisher_info_db
• ensured that publisher_info_db was being updated via the BR panel and brave://rewards

Verification passed on

Brave	0.63.44 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision	fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS	Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#2122

[kjozwiak]

@jasonrsadler just a quick question. When upgrading the v3 database to the v4 database, the two database schema's look the same. Is there a way to tell if the database was updated to v4?

Edited: @jasonrsadler mentioned that the version number is displayed in the meta table 👍