Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on Sync Page #4088

Closed
jonathansampson opened this issue Apr 12, 2019 · 2 comments · Fixed by brave/brave-core#2259
Closed

Typo on Sync Page #4088

jonathansampson opened this issue Apr 12, 2019 · 2 comments · Fixed by brave/brave-core#2259
Assignees
@rossmoody
Labels
about-pages/sync bug needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.65.x - Release ...

Comments

@jonathansampson
Copy link
Contributor

Description

Small typo on brave://sync. The page should say affect rather than effect. This issue was reported by a user on twitter: https://twitter.com/jackbremer/status/1116788373329518593

Actual result:

image

Brave version (brave://version info)

0.62.51
@rebron
Copy link
Collaborator

rebron commented Apr 13, 2019

cc: @AlexeyBarabash @rossmoody Can you take a look and grab this one? It should be "affect" instead of effect.

@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Apr 15, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 17, 2019
@rossmoody rossmoody mentioned this issue Apr 17, 2019
Merged
@rebron rebron added this to the 0.66.x - Nightly milestone May 6, 2019
@rebron rebron modified the milestones: 0.66.x - Dev, 0.65.x - Beta May 14, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 15, 2019 •
edited by btlechowski
Loading

Verification passed on

Brave 0.65.93 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image

Verified passed with

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Screen Shot 2019-05-17 at 4 28 29 PM

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

image

@rossmoody rossmoody mentioned this issue May 25, 2019
Merged
@LaurenWags LaurenWags mentioned this issue May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
about-pages/sync bug needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update Sync strings brave/brave-core
8 participants
@jonathansampson @bsclifton @rebron @srirambv @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya