Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sync strings #2259

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Update Sync strings #2259

merged 1 commit into from
Apr 22, 2019

Conversation

rossmoody
Copy link
Contributor

@rossmoody rossmoody added this to the 0.65.x - Nightly milestone Apr 17, 2019
@rossmoody rossmoody self-assigned this Apr 17, 2019
rebron
rebron approved these changes Apr 21, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rossmoody rossmoody merged commit 06767cf into master Apr 22, 2019
@rossmoody rossmoody deleted the sync-strings-3 branch April 22, 2019 17:38
brave-builds pushed a commit that referenced this pull request Apr 22, 2019
@brave-browser-releases
Uplift of #2259 (squashed) to dev
161cf03
brave-builds pushed a commit that referenced this pull request Apr 22, 2019
@brave-browser-releases
Uplift of #2259 (squashed) to beta
28c5c4c
This was referenced Apr 22, 2019
Merged
Closed
@bsclifton bsclifton modified the milestones: 0.66.x - Dev, 0.65.x - Beta May 23, 2019
@iccub iccub mentioned this pull request Jul 10, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron approved these changes

@cezaraugusto cezaraugusto Awaiting requested review from cezaraugusto

Assignees

@rossmoody rossmoody

Labels
feature/sync
Projects
None yet
Milestone
0.66.x - Release
Development

Successfully merging this pull request may close these issues.

Sync should show warning not to share the code with anyone Typo on Sync Page
4 participants
@rossmoody @rebron @bsclifton @NejcZdovc