Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval details and Estimated balance details are hidden in transaction simulation #40958

Closed
2 of 6 tasks
srirambv opened this issue Sep 10, 2024 · 2 comments · Fixed by brave/brave-core#25611
Closed
2 of 6 tasks

Comments

@srirambv
Copy link
Contributor

Description

Approval details and Estimated details are hidden in transaction simulation

Steps to reproduce

  1. Enable transaction simulation
  2. Create a Send/Swap EVM transaction
  3. Close and reopen panel
  4. Shows pending transaction but Approval and Estimated balance section is not shown
  5. Switch to Details view and go back to transaction, shows the details

Actual result

brave_8hJc7MkBIx.mp4

Expected result

Should not hide transaction details

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.70.107 Chromium: 128.0.6613.120 (Official Build) beta (64-bit)
Revision ab3f504ca4a15c330f60a93d5e3773d780498980
OS Windows 11 Version 23H2 (Build 22631.4112)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @onyb @Douglashdaniel

@kjozwiak
Copy link
Member

The above requires 1.71.92 or higher for 1.71.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Oct 1, 2024

Verification passed on

Brave 1.71.97 Chromium: 129.0.6668.70 (Official Build) beta (64-bit)
Revision de99cbcb1aa0aa00877d356e4733f4e5481e89eb
OS Windows 11 Version 23H2 (Build 22631.4169)
  • Verified steps from issue description and brave/brave-core#25611
  • Verified Transaction simulations details are not hidden when cycling through pending transactions
40958.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants