Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Transaction Simulations Hidden Details (uplift to 1.71.x) #25634

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix(wallet): Transaction Simulations Hidden Details (uplift to 1.71.x) #25634

merged 1 commit into from
Sep 21, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 18, 2024 •
edited by kjozwiak
Loading

Uplift of #25611
Resolves brave/brave-browser#40958

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 18, 2024 14:17
@brave-builds brave-builds added this to the 1.71.x - Beta milestone Sep 18, 2024
@brave-builds brave-builds self-assigned this Sep 18, 2024
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Sep 18, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@mherrmann mherrmann force-pushed the pr25611_fix-wallet-tx-simulations-hidden-details_1.71.x branch from 0be970e to 3b9064e Compare September 19, 2024 03:36
@mherrmann
Copy link
Collaborator

@kjozwiak this failed on macOS with the usual error in dist so I've taken the liberty of rebasing, so we get #25632.

@Douglashdaniel Douglashdaniel force-pushed the pr25611_fix-wallet-tx-simulations-hidden-details_1.71.x branch from 3b9064e to 51d54fb Compare September 20, 2024 20:15
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.71.x approved 👍 QA has verified the PR on Nightly using 1.72.x as per #25611 (comment).

@kjozwiak kjozwiak merged commit fb02d2f into 1.71.x Sep 21, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr25611_fix-wallet-tx-simulations-hidden-details_1.71.x branch September 21, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Milestone
1.71.x - Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @mherrmann @kjozwiak