-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Brave Ads catalog not pulled every 2 hours - follow up to 3520 #4161
Comments
Reproduced the issue with above build. STR:
|
Went through the following last night which appeared to be working:
@LaurenWags as per our discussion, can you try the following whenever you have some time?
Are you getting pings after ~2hrs once the machine woke up? |
Ran the following test:
Seems like it is working in that after being asleep, the machine did eventually pull a new catalog. However, my concern is that after being asleep for over 2 hours, neither pulled a new catalog on waking up. If a user does the following
|
@LaurenWags Totally agree, does this also happen on Ledger? |
@tmancey I'm unsure what your question means. Could you provide a bit more detail? |
@LaurenWags I have spoken with @NejcZdovc and Ledger also has timers which trigger after a specified amount of time, so it is likely that Ledger is also affected when the device goes to sleep. I will discuss solutions with @NejcZdovc |
cc @LaurenWags @btlechowski this was due to the use of OneShotTimer. We should use WallClockTimer which runs after a delay based on usual time, while OneShotTimer runs after a delay according to TimeTicks which may freeze on some platforms when power suspends (i.e. desktop falls asleep). On platforms where TimeTicks don't freeze, the WallClockTimer has the same behavior as OneShotTimer. |
Verified with
Initial catalog request/response:
Let computer sleep for ~2hr (past the Confirmed on computer wake a new catalog was fetched:
|
Description
Found while testing #3520
While testing I have not been getting a new Ads catalog every two hours. Others have not experienced this (@kjozwiak @tmancey ). I wonder if it's because when my computer sleeps it's turning off hard disks and this is possibly disrupting things.
Steps to Reproduce
Still TBD. I'm testing different scenarios/builds and will add notes as comments to this issue. Once steps are found, I'll put them here.
Actual result:
Catalog not downloaded every 2 hours
Expected result:
Catalog downloaded every 2 hours
Reproduces how often:
reproduces easily for me, not for others.
Brave version (brave://version info)
Experienced with the following versions:
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: