Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bat-native-ads dep #3520

Closed
tmancey opened this issue Feb 27, 2019 · 5 comments · Fixed by brave/brave-core#1795
Closed

Bump bat-native-ads dep #3520

tmancey opened this issue Feb 27, 2019 · 5 comments · Fixed by brave/brave-core#1795

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 27, 2019

Bump bat-native-ads dep

@srirambv
Copy link
Contributor

srirambv commented Apr 5, 2019

Verification passed on both

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
Brave 0.64.37 Chromium: 74.0.3729.40 (Official Build) dev(64-bit)
Revision 278d6a0d856d8314f36fb9a68b6e1d85cd0d14e7-refs/branch-heads/3729@{#470}
OS Linux
  • Verified on console logs Successfully downloaded catalog shows up after two hours

Verification passed on

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Windows 10 OS Build 17134.523

Verification PASSEDD on macOS 10.14.4 x64 using the following build:

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

After leaving my machine on over night, received several of these update/pings in the terminal:

[22265:775:0418/062239.244838:INFO:ads_serve.cc(64)] Successfully downloaded catalog
[22265:775:0418/062239.245157:INFO:ads_serve.cc(137)] Parsing catalog
[22265:775:0418/062239.248499:INFO:catalog.cc(37)] Successfully loaded catalog
[22265:775:0418/062239.248736:INFO:ads_serve.cc(143)] Catalog parsed
[22265:775:0418/062239.248920:WARNING:ads_serve.cc(151)] Catalog id 0b08fca8634b04875acd794528fc3724929b4818 matches current catalog id 0b08fca8634b04875acd794528fc3724929b4818

@kjozwiak
Copy link
Member

Seemed to work for me so I updated #3520 (comment). However, @LaurenWags seems to be having some issues so we'll close off verification on macOS once @LaurenWags confirms it's working.

@LaurenWags
Copy link
Member

@kjozwiak logged #4161 as a follow up issue for what I'm seeing. I'm going to continue to investigate (consulting with @tmancey as well on this).

@kjozwiak
Copy link
Member

Sounds good @LaurenWags 👍I'll give it another try tonight with the monitor put to sleep but will keep the network/hard disk on and see if that scenario works. The scenario of everything on is working for me though 👍

@kjozwiak
Copy link
Member

Labelling this as verified for macOS. Follow up investigation/work will be added into #4161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment